8000 Optimize NUKE spell check by IT-VBFK · Pull Request #2089 · fluentassertions/fluentassertions · GitHub
[go: up one dir, main page]
Skip to content

Optimize NUKE spell check#2089

Merged
dennisdoomen merged 9 commits intofluentassertions:developfrom
IT-VBFK:optimize-nuke-spellcheck
Jan 8, 2023
Merged

Optimize NUKE spell check#2089
dennisdoomen merged 9 commits intofluentassertions:developfrom
IT-VBFK:optimize-nuke-spellcheck

Conversation

@IT-VBFK
Copy link
Contributor
@IT-VBFK IT-VBFK commented Jan 7, 2023 •
edited
Loading

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

With friendly support from nuke-build/nuke#1098 (comment) :)

This is a follow-up for #2086. Now NUKE checks if changes are made inside the docs/ folder and running spell check depending on that.

Please note: this is only a first rough sketch how it can look like. So discussion is needed if this change is really necessary.

The only (possible) drawback is: You have to commit at least one change in the docs/ folder.

@coveralls
Copy link
coveralls commented Jan 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3861534102

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 96.922%
Totals Coverage Status
Change from base Build 3857089136: 0.9%
Covered Lines: 12449
Relevant Lines: 12692
💛 - Coveralls

@IT-VBFK IT-VBFK force-pushed the optimize-nuke-spellcheck branch 2 times, most recently from 3286252 to bf793e2 Compare January 7, 2023 08:49
@IT-VBFK IT-VBFK marked this pull request as ready for review January 7, 2023 08:50
@IT-VBFK IT-VBFK force-pushed the optimize-nuke-spellcheck branch 6 times, most recently from fcf9dd1 to b819f8b Compare January 7, 2023 09:48
@IT-VBFK IT-VBFK force-pushed the optimize-nuke-spellcheck branch from b819f8b to 5494599 Compare January 7, 2023 09:50
dennisdoomen
dennisdoomen requested changes Jan 7, 2023
10000
View reviewed changes
Copy link
Member
@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

🔧 You also need to update the main build YAML and remove the new one you introduced in the other PR

@IT-VBFK IT-VBFK requested a review from dennisdoomen January 7, 2023 11:09
@dennisdoomen dennisdoomen requested a review from jnyrup January 7, 2023 12:03
dennisdoomen
dennisdoomen reviewed Jan 7, 2023
View reviewed changes
IT-VBFK
IT-VBFK commented Jan 7, 2023
View reviewed changes
@IT-VBFK IT-VBFK force-pushed the optimize-nuke-spellcheck branch from e90fe4d to d9bb300 Compare January 7, 2023 12:25
jnyrup
jnyrup approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member
@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm learning a lot about NUKE from these PRs 🚀

@IT-VBFK IT-VBFK force-pushed the optimize-nuke-spellcheck branch from b7b4de5 to e46e75c Compare January 7, 2023 19:57
@IT-VBFK
Copy link
Contributor Author
IT-VBFK commented Jan 7, 2023 •
edited
Loading

Should this PR be squashed with the previous "cSpell to NUKE" commit?

Technically it is no new feature, but an improvement of a none released feature.

Reason why I ask: Now (if I understand the release notes template correctly) there would be four entries about this one feature. Is this correct?

This was referenced Sep 15, 2025
Closed
Closed
This was referenced Sep 25, 2025
Closed
Closed
Closed
Closed
This was referenced Oct 3, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 13, 2025
Closed
This was referenced Oct 20, 2025
Closed
Closed
Open
Open
This was referenced Oct 27, 2025
Closed
Closed
This was referenced Nov 10, 2025
Closed
Closed
This was referenced Nov 24, 2025
Closed
Open
This was referenced Dec 1, 2025
Closed
Closed
Merged
Closed
This was referenced Dec 22, 2025
Open
Closed
This was referenced Jan 11, 2026
Merged
Open
@dependabot dependabot bot mentioned this pull request Feb 8, 2026
Merged
This was referenced Mar 2, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IT-VBFK @coveralls @dennisdoomen @jnyrup
0