8000 Add `ThatAre[Not]Interfaces` to `TypeSelector.cs` by 94sedighi · Pull Request #2057 · fluentassertions/fluentassertions · GitHub
[go: up one dir, main page]
Skip to content

Add ThatAre[Not]Interfaces to TypeSelector.cs#2057

Merged
jnyrup merged 15 commits intofluentassertions:developfrom
94sedighi:TypeSelectorInterfaceFeature
Dec 21, 2022
Merged

Add ThatAre[Not]Interfaces to TypeSelector.cs#2057
jnyrup merged 15 commits intofluentassertions:developfrom
94sedighi:TypeSelectorInterfaceFeature

Conversation

@94sedighi
Copy link
Contributor
@94sedighi 94sedighi commented Dec 5, 2022 •
edited
Loading

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.

@94sedighi 94sedighi changed the title Add ThatAre[Not]Interface to TypeSelector as mentioned in Issue #645 Add ThatAre[Not]Interface to TypeSelector.cs as mentioned in Issue #645 Dec 5, 2022
@94sedighi 94sedighi changed the title Add ThatAre[Not]Interface to TypeSelector.cs as mentioned in Issue #645 Add ThatAre[Not]Interface to TypeSelector.cs Dec 6, 2022
@94sedighi 94sedighi marked this pull request as ready for review December 6, 2022 10:50
@coveralls
Copy link
coveralls commented Dec 8, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3730544120

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 96.895%
Totals Coverage Status
Change from base Build 3730045467: 0.9%
Covered Lines: 12474
Relevant Lines: 12721
💛 - Coveralls

@jnyrup jnyrup added the feature label Dec 12, 2022
dennisdoomen
dennisdoomen requested changes Dec 18, 2022
View reviewed changes
dennisdoomen
dennisdoomen requested changes Dec 19, 2022
View reviewed changes
@dennisdoomen dennisdoomen requested a review from jnyrup December 19, 2022 09:16
jnyrup
jnyrup requested changes Dec 19, 2022
View reviewed changes
@94sedighi 94sedighi changed the title Add ThatAre[Not]Interface to TypeSelector.cs Add ThatAre[Not]Interfaces to TypeSelector.cs Dec 19, 2022
@94sedighi 94sedighi requested review from dennisdoomen and jnyrup and removed request for dennisdoomen and jnyrup December 19, 2022 10:43
@dennisdoomen
Copy link
Member
dennisdoomen commented Dec 19, 2022

Needs a rebase

@94sedighi
Copy link
Contributor Author
94sedighi commented Dec 19, 2022

Needs a rebase

The problem is, when you approve a PR then i get conflicts and have to resolve the conflicts and commit the changes. Then you have to review it again. Sorry for the circumstances. i don't know how to do it efficiently.
I will make a new commit.

@dennisdoomen
Copy link
Member
dennisdoomen commented Dec 19, 2022

The problem is, when you approve a PR then i get conflicts and have to resolve the conflicts and commit the changes. Then you have to review it again. Sorry for the circumstances. i don't know how to do it efficiently.

No need to re-review.

@dennisdoomen
Copy link
Member
dennisdoomen commented Dec 19, 2022

But looking at the commits, it seems that you are not using the rebase option. If you're not conformable with that, I strongly recommend digging into the principles of rebasing. It results in a much cleaner source control history.

@jnyrup jnyrup mentioned this pull request Dec 19, 2022
Closed
88 tasks
@94sedighi 94sedighi force-pushed the TypeSelectorInterfaceFeature branch from 4c13f74 to 6f84f10 Compare December 20, 2022 12:44
This was referenced Sep 15, 2025
Closed
Closed
This was referenced Sep 25, 2025
Closed
Closed
Closed
Closed
This was referenced Oct 3, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 13, 2025
Closed
This was referenced Oct 20, 2025
Closed
Closed
Open
Open
This was referenced Oct 27, 2025
Closed
Closed
This was referenced Nov 10, 2025
Closed
Closed
This was referenced Nov 24, 2025
Closed
Open
This was referenced Dec 1, 2025
Closed
Closed
Merged
Closed
This was referenced Dec 22, 2025
Open
Closed
This was referenced Jan 11, 2026
Merged
Open
@dependabot dependabot bot mentioned this pull request Feb 8, 2026
Merged
This was referenced Mar 2, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@94sedighi @coveralls @dennisdoomen @jnyrup
0