8000 Revert "Add the ability to exclude non-browsable members from equivalency tests" by jnyrup · Pull Request #1842 · fluentassertions/fluentassertions · GitHub
[go: up one dir, main page]

Skip to content

Revert "Add the ability to exclude non-browsable members from equivalency tests"#1842

Merged
jnyrup merged 1 commit intodevelopfrom
revert-1807-JDG_ExcludingNonBrowsable
Mar 11, 2022
Merged

Revert "Add the ability to exclude non-browsable members from equivalency tests"#1842
jnyrup merged 1 commit intodevelopfrom
revert-1807-JDG_ExcludingNonBrowsable

Conversation

@jnyrup
Copy link
Member
@jnyrup jnyrup commented Mar 10, 2022

As there is an ongoing discussion in #1827 about the design of ExcludingNonBrowsableMembers, we have to revert #1807, to avoid blocking releasing a new version of Fluent Assertions, until we eventually get the design right.

cc: @logiclrd

@jnyrup jnyrup requested a review from dennisdoomen March 10, 2022 18:43
@jnyrup jnyrup force-pushed the revert-1807-JDG_ExcludingNonBrowsable branch from 622ba79 to 9c2cc12 Compare March 10, 2022 18:54
@coveralls
Copy link
coveralls commented Mar 10, 2022

Pull Request Test Coverage Report for Build 1964941130

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 95.837%

Totals Coverage Status
Change from base Build 1941743704: -0.009%
Covered Lines: 11366
Relevant Lines: 11721

💛 - Coveralls

@jnyrup jnyrup merged commit 16d6312 into develop Mar 11, 2022
@jnyrup jnyrup deleted the revert-1807-JDG_ExcludingNonBrowsable branch March 12, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0