Python 3.5 Support #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Python 3.5 always failed with pip command error. https://travis-ci.org/fluent/fluent-logger-python/jobs/104087120 |
Contributor
Author
|
Correct, |
Contributor
Author
|
Tests are hanging on most runners - this seems to happen occasionally with your build :/ |
Also make Travis tests go a bit faster using `sudo: false` to use containers as per https://docs.travis-ci.com/user/workers/container-based-infrastructure/ Test Plan: local `tox` + Travis build attached to PR.
Member
|
Hmm... tests are unstable. |
Member
|
py3.5 test is passed so merged. |
Contributor
Author
|
😸 🐍 3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make Travis tests go a bit faster using
sudo: falseto use containers as per https://docs.travis-ci.com/user/workers/container-based-infrastructure/Test Plan: local
tox+ Travis build attached to PR.