8000 Fix typo by mmasaki · Pull Request #40 · fluent/fluent-logger-python · GitHub
[go: up one dir, main page]
Skip to content

Fix typo #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2015
Merged

Fix typo #40

merged 1 commit into from
Sep 28, 2015

Conversation

mmasaki
Copy link
Contributor
@mmasaki mmasaki commented Sep 28, 2015

No description provided.

portante
portante reviewed Sep 28, 2015
View reviewed changes
README.md
@@ -76,7 +76,7 @@ from fluent import handler

custom_format = {
'host': '%(hostname)s',
'where': '%(module)s.%(funcName)s'
'where': '%(module)s.%(funcName)s',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change. Can you share a symptom for where we'd see this?

@yyuu
Copy link
Member
yyuu commented Sep 28, 2015

Test is broken with py32 by inappropriate version of coverage. I'd fix it later.

yyuu added a commit that referenced this pull request Sep 28, 2015
@yyuu
Pin coverage version to pass test with Python 3.2 (#40)
eca4260 
https://travis-ci.org/fluent/fluent-logger-python/jobs/82487668
yyuu added a commit that referenced this pull request Sep 28, 2015
@yyuu
Merge pull request #40 from mmasaki/fix_typo
875bc72 
Fix typo
@yyuu yyuu merged commit 875bc72 into fluent:master Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmasaki @yyuu @portante
0