Misc fixes and cosmetics #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix indentation, spacing, imports order, variable names, etc.
According to documentation and existing functions:
* _close should be close and call Handler close to properly
unregister from existing handlers
* emit should not re-filter logs, it is handled by the format
function.
* __init__ should not set a formatter, it is the responsability of
the dev to do so. Old code forbid subclassing the formatter and
using it.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've found a few oddities in this module so I went ahead and fixed them.
I also ran the code through pep8 and pylint to clean things up a bit, enjoy.