fix(FloatingFocusManager): check for blurring to nested elements inside the React tree without FloatingTree
#3318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 13217d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vibrant-gates-22c214 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@floating-ui/core
@floating-ui/dom
@floating-ui/react
@floating-ui/react-dom
@floating-ui/react-native
@floating-ui/utils
@floating-ui/vue
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3060
When the nested floating element isn't nested inside the parent's portal element (changing the
rootonFloatingPortalto escape this behavior), it closes unexpectedly becausefocusoutis triggered and the handler doesn't have knowledge of the React tree, only the DOM tree.This PR changes this by using the same capture phase technique to let the handler know it's inside the React tree, to avoid needing to setup
FloatingTree. This is how outside press is handled already.One caveat is that it requires
useDismissto be used in conjunction withFloatingFocusManagerto work becauseFloatingFocusManagercan't assign React props. (It seems thecloseOnFocusOutlogic inFloatingFocusManagercould better live insideuseDismissinstead - a possible refinement for v1).Solving nested
useHoverstill requiresFloatingTreeat this time, but I need to investigate how that could work.