fix(authn): forward state and token cookies to distinct metadata keys#5479
Merged
fix(authn): forward state and token cookies to distinct metadata keys#5479
Conversation
ForwardCookies was writing both flipt_client_state and flipt_client_token cookies into the flipt_client_state metadata key. When both cookies were present, callback state validation could fail with "unexpected state parameter", commonly after restart when a stale token cookie existed. Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
|
Related Documentation Checked 4 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #5479 +/- ##
==========================================
+ Coverage 59.94% 60.40% +0.45%
==========================================
Files 141 141
Lines 13995 13995
==========================================
+ Hits 8389 8453 +64
+ Misses 4890 4821 -69
- Partials 716 721 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForwardCookies was writing both flipt_client_state and flipt_client_token
cookies into the flipt_client_state metadata key. When both cookies were
present, callback state validation could fail with "unexpected state parameter",
commonly after restart when a stale token cookie existed.