fix(evaluation): extract environment fallback logic to helper method#4959
Merged
fix(evaluation): extract environment fallback logic to helper method#4959
Conversation
Extracted duplicate environment retrieval logic with context fallback into a reusable getCurrentEnvironment helper method. This ensures consistent environment lookup behavior across both snapshot endpoints. Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
|
Documentation Updates Checked 4 published document(s). No updates required. How did I do? Any feedback? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #4959 +/- ##
=======================================
Coverage 60.29% 60.29%
=======================================
Files 136 136
Lines 13372 13375 +3
=======================================
+ Hits 8062 8065 +3
Misses 4629 4629
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markphelps
approved these changes
Oct 29, 2025
Collaborator
There was a problem hiding this comment.
thank you i'll create a new release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted duplicate environment retrieval logic with context fallback
into a reusable getCurrentEnvironment helper method. This ensures
consistent environment lookup behavior across both snapshot endpoints.
closes #4958