fix(analytics): return all batch data for requested flags#4756
Merged
Conversation
Currently the batch analytics returns only data for one flag. Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
|
Related Documentation Checked 3 published document(s). No updates required. You have 3 draft document(s). Publish docs to keep them always up-to-date How did I do? Any feedback? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #4756 +/- ##
=======================================
Coverage 62.64% 62.64%
=======================================
Files 132 132
Lines 15531 15531
=======================================
Hits 9730 9730
Misses 5115 5115
Partials 686 686
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Documentation Updates Checked 3 published document(s). No updates required. You have 3 draft document(s). Publish docs to keep them always up-to-date How did I do? Any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor adjustment to the logic for tracking timestamps in the
GetBatchFlagEvaluationsCountmethod. The change moves the line that appends a timestamp to thetimestampsmap outside of a conditional block, ensuring that every timestamp is appended for each flag key, regardless of whether it is already present inorderedTimestamps.Currently the batch analytics returns only data for one flag.