8000 Call dispose later from __del__ so it gets called in Tornados handlers by almarklein · Pull Request #404 · flexxui/flexx · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call dispose later from __del__ so it gets called in Tornados handlers #404

Merged
merged 5 commits into from
Oct 8, 2017
Merged

Call dispose later from __del__ so it gets called in Tornados handlers #404

merged 5 commits into from
Oct 8, 2017

Conversation

almarklein
Copy link
Member
@almarklein almarklein commented Oct 6, 2017 •
edited
Loading

This hopefully fixes:

Exception ignored in: <bound method HasEvents.__del__ of <Visual object 'Visual70' at 0x22a3393d780>>
Traceback (most recent call last):
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\flexx\event\_hasevents.py", line 188, in __del__
    self.dispose()
    File "C:\Users\john\Projects\xx\xx\viz\visuals\visual.py", line 65, in dispose
    self.children = ()
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\flexx\app\_model.py", line 500, in __setattr__
    event.HasEvents.__setattr__(self, name, value)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\flexx\event\_emitters.py", line 121, in __set__
    return instance._set_prop(self._name, value)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\flexx\app\_model.py", line 538, in _set_prop
    self._session._exec(cmd)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\flexx\app\_session.py", line 620, in _exec
    self._send_command('EXEC ' + code)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\flexx\app\_session.py", line 562, in _send_command
    self._ws.command(command)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\flexx\app\_tornadoserver.py", line 671, in command
    self.write_message(cmd, binary=BINARY)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\tornado\websocket.py", line 252, in write_message
    return self.ws_connection.write_message(message, binary=binary)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\tornado\websocket.py", line 785, in write_message
    return self._write_frame(True, opcode, message, flags=flags)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\tornado\websocket.py", line 768, in _write_frame
    return self.stream.write(frame)
    File "C:\Users\john\Miniconda3\envs\xx\lib\site-packages\tornado\iostream.py", line 395, in write
    self._write_buffer += data
BufferError: Existing exports of data: object cannot be re-sized

See also:

@almarklein
Copy link
Member Author

cc @ivoflipse

ivoflipse
ivoflipse approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor
@ivoflipse ivoflipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't reproduce the error anymore, so that seems good

@almarklein almarklein merged commit 82f79c4 into master Oct 8, 2017
@almarklein almarklein deleted the call-dispose-later branch October 8, 2017 14:44
@almarklein almarklein added this to the v0.4.2 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoflipse ivoflipse ivoflipse approved these changes

Assignees
No one assigned
Labels
PR: ready tag: app tag: event type: bug
Projects
None yet
Milestone
v0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@almarklein @ivoflipse
0