Update for compatibility with flask v2.3.2 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 2.3.0 of flask, the JSONEncoder class was removed and the app.json_encoder attribute was removed. The result that a run of the tests using flask==2.3.0 would fail. This change updates the use of flask's json mechanisms to be in line with the new standard, and similarly updates the tests to utilize those mechanisms correctly.
auvipy
approved these changes
Jun 3, 2023
|
@auvipy thank you for the quick review and merge! Do you have any idea when it might be possible to release a new version to pypi? |
|
@jacebrowning can we get a new release? |
|
#155 for the next release following these instructions. |
|
thanks a lot. I will follow that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 2.3.0 of flask, the JSONEncoder class was removed and the app.json_encoder attribute was removed. The result that a run of the tests using flask==2.3.0 would fail. This change updates the use of flask's json mechanisms to be in line with the new standard, and similarly updates the tests to utilize those mechanisms correctly.
From other pull requests I wasn't able to tell whether there is still a Travis project that is watching this repository, but if there is and if I've understood the setup correctly, the tests should validate that this change causes the tests to pass with flask 2.3.2
Closes #151