Conversation
|
Claude finished @ZanCorDX's task in 1m 15s —— View job Review SummaryI've reviewed this PR which adds ARM64 Docker support and optimizes build speed by reusing pre-built binaries. Issues Found1. Inconsistent base image versions (docker/Dockerfile.rbuilder-from-binary:5)
2. ARM64 build doesn't benefit from speed optimization (.github/workflows/release.yaml:389)
3. Minor: No timeout on manifest creation step (.github/workflows/release.yaml:423)
Additional Observations
Tasks
|
| # The CI job downloads the linux/amd64 rbuilder binary into the build context as ./rbuilder | ||
| # Artifact download does not preserve execute bit; --chmod sets it on copy. | ||
|
|
||
| FROM gcr.io/distroless/cc-debian13 |
There was a problem hiding this comment.
The existing Dockerfile.rbuilder uses cc-debian12 but this uses cc-debian13. Consider keeping consistency between Dockerfiles:
| FROM gcr.io/distroless/cc-debian13 | |
| FROM gcr.io/distroless/cc-debian12 |
If debian13 is intentional (e.g., for newer glibc compatibility), consider updating Dockerfile.rbuilder as well to maintain consistency.
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: docker build and push (from source, native arm64) |
There was a problem hiding this comment.
The ARM64 build does not attempt to download and reuse a pre-built binary like the AMD64 job does. This means ARM64 always builds from source, missing the speed improvement mentioned in the PR description.
Consider adding a build-binary job for aarch64-unknown-linux-gnu target, then download and use it here similar to the AMD64 job.
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Create and push multi-arch manifest 8000 |
There was a problem hiding this comment.
Consider adding a timeout-minutes to the script to prevent indefinite hanging if imagetools inspect or imagetools create stalls.
📝 Summary
✅ I have completed the following steps:
make lintmake test