8000 refactor!: `isEnabled` getter and setter by alestiago · Pull Request #65 · flame-engine/forge2d · GitHub
[go: up one dir, main page]
Skip to content

refactor!: isEnabled getter and setter#65

Merged
spydon merged 13 commits intoflame-engine:mainfrom
alestiago:refactor/enabled-getter-and-setter
Aug 26, 2022
Merged

refactor!: isEnabled getter and setter#65
spydon merged 13 commits intoflame-engine:mainfrom
alestiago:refactor/enabled-getter-and-setter

Conversation

@alestiago
Copy link
Collaborator
@alestiago alestiago commented Jul 21, 2022 •
edited
Loading

Description

Removed setEnabled and isEnabled. Also updated documentation for the new getter and setter.

// Before:
contact.setEnabled(true);
contact.isEnabled(); // true

// After:
contact.isEnabled = true;
contact.isEnabled; // true

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

spydon
spydon reviewed Aug 22, 2022
View reviewed changes
@alestiago alestiago requested a review from spydon August 24, 2022 22:08
spydon
spydon reviewed Aug 26, 2022
View reviewed changes
@spydon spydon enabled auto-merge (squash) August 26, 2022 08:50
auto-merge was automatically disabled August 26, 2022 08:56

Head branch was pushed to by a user without write access

@spydon spydon changed the title refactor!: enabled getter and setter refactor!: isEnabled getter and setter Aug 26, 2022
@spydon spydon merged commit 839e53a into flame-engine:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spydon spydon spydon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alestiago @spydon
0