8000 refactor!: used getter and setters for maxMotorForce by alestiago · Pull Request #62 · flame-engine/forge2d · GitHub
[go: up one dir, main page]
Skip to content

refactor!: used getter and setters for maxMotorForce#62

Merged
spydon merged 3 commits intoflame-engine:mainfrom
alestiago:refactor/use-dart-getter-and-setter-max-motor-force
Aug 22, 2022
Merged

refactor!: used getter and setters for maxMotorForce#62
spydon merged 3 commits intoflame-engine:mainfrom
alestiago:refactor/use-dart-getter-and-setter-max-motor-force

Conversation

@alestiago
Copy link
Collaborator
@alestiago alestiago commented Jul 20, 2022 •
edited
Loading

Description

Changes:

  • Renamed getMaxMotorForce to maxMotorForce (now a Dart setter)
  • Renamed setMaxMotorForce to maxMotorForce (now a Dart getter)
// Before:
final joint = PrismaticJoint(jointDef);
joint.setMaxMotorForce(20); // Sets max motor force
joint.getMaxMotorForce; // Gets max motor force (20)

// After:
final joint = PrismaticJoint(jointDef);
joint.maxMotorForce = 20; // Sets max motor force
joint.maxMotorForce; // Gets max motor force (20)

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@alestiago
Copy link
Collaborator Author
alestiago commented Jul 21, 2022

(cc: @spydon)

@spydon
Copy link
Member
spydon commented Jul 21, 2022

Looks good, all these kind of getter/setters that need to be converted should be merged at the same time. I'm guessing there are quite a few left?

@alestiago
Copy link
Collaborator Author
alestiago commented Jul 21, 2022 •
edited
Loading

There are quite a few left indeed. I have local branches with them, once I can I'll raise the PRs.

@spydon spydon enabled auto-merge (squash) August 22, 2022 18:51
@spydon spydon merged commit 4ab2eb2 into flame-engine:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spydon spydon spydon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alestiago @spydon
0