10000 Make KernelCenterer a _pairwise operation by fishcorn · Pull Request #1 · fishcorn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Make KernelCenterer a _pairwise operation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make KernelCenterer a _pairwise operation #1

wants to merge 1 commit into from

Conversation

fishcorn
Copy link
Owner
@fishcorn fishcorn commented Jun 17, 2016 •
edited
Loading

Reference Issue

EDIT: scikit-learn#803 is the relevant PR for fixing KernelPCA in Pipelines

What does this implement/fix? Explain your changes.

Allows for using KernelCenterer in Pipelines.

Any other comments?

Replicate solution to scikit-learn@9a52077 except that _pairwise should always be True for KernelCenterer because it's supposed to receive a Gram matrix. This should make KernelCenterer usable in Pipelines.

Happy to add tests, just tell me what should be covered.

@fishcorn
Make KernelCenterer a _pairwise operation
2242b1b 
Replicate solution to scikit-learn@9a52077 except that `_pairwise` should always be `True` for `KernelCenterer` because it's supposed to receive a Gram matrix. This should make `KernelCenterer` usable in `Pipeline`s.

Happy to add tests, just tell me what should be covered.
@fishcorn fishcorn closed this Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fishcorn
0