Replace more escapes with quotes in man parser#9961
Merged
faho merged 2 commits intofish-shell:masterfrom Aug 19, 2023
ysthakur:master-1
Merged
Replace more escapes with quotes in man parser#9961faho merged 2 commits intofish-shell:masterfrom ysthakur:master-1
faho merged 2 commits intofish-shell:masterfrom
ysthakur:master-1
Conversation
Member
|
Isn't roff lovely?
I can find
So the first and second would be double quotes, the third single-quotes. RE your TODO comments: These are all fine. We can add it to the CHANGELOG if we decide before a release. |
Contributor
Author
|
Great, I added those 4 in too. |
Member
|
Merged, thanks! |
faho
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Replace \(aq with "'" in man parser * Also replace oq, dq, lq, and rq (cherry picked from commit 0f19d71)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to #7086, which is about
\(cq. At least one man page (df) uses\(aq, so this PR replaces those with single quotes. I haven't found any examples other thandf, though.I don't understand roff, but looking at the GNU Troff manual,
dq,lq,oq, andrqmay also have to be replaced with quotes, in addition tocqandaq.dqis a neutral double quote.lqseems to be used for left double quotes andrqfor right double quotes, but I assume both can safely be replaced with neutral double quotes. I have no idea whatoqis.TODOs:
User-visible changes noted in CHANGELOG.rst<- This change isn't particularly user-visible, right?dq,lq,oq, orrqand, if they exist, add them to this PR?