webconfig.py: minor polish of is_chromeos_garcon
#8596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `name` attribute I used in commit f725cd4 is undocumented, and [someone discovered] that it does not exist for one possible browser on MacOS. This should make the code work correctly even in that case. This probably doesn't currently cause a problem, at least when `isMacOS10_12_5_OrLater()` is true, because of the ordering of the if statements in the `runThing` function. [someone discovered]: https://bugs.python.org/issue43424#msg409087
|
I forgot to mention in the commit message: the |
|
Merged, thanks! (no need for a changelog entry) |
|
Thank you!
…On Thu, Dec 30, 2021 at 3:56 AM Fabian Homborg ***@***.***> wrote:
Merged, thanks!
(no need for a changelog entry)
—
Reply to this email directly, view it on GitHub
<#8596 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7OTJZXJGEMWT7PWIEZNFDUTRCHVANCNFSM5K67ADHQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nameattribute I used in commit f725cd4is undocumented, and someone discovered that it does not exist for one
possible browser on MacOS. This should make the code work correctly even in that case.
This probably doesn't currently cause a problem, at least when
isMacOS10_12_5_OrLater()is true, because of the ordering of the ifstatements in the
runThingfunction.TODOs: