8000 Add missing completions for some git commands by thunder-coding · Pull Request #8134 · fish-shell/fish-shell · GitHub
[go: up one dir, main page]

Skip to content

Add missing completions for some git commands#8134

Merged
faho merged 12 commits intofish-shell:masterfrom
thunder-coding:complete-more-git-commands
Jul 23, 2021
Merged

Add missing completions for some git commands#8134
faho merged 12 commits intofish-shell:masterfrom
thunder-coding:complete-more-git-commands

Conversation

@thunder-coding
Copy link
Contributor
@thunder-coding thunder-coding commented Jul 12, 2021

Add missing completions for some Git commands

Completions planned to be done in this PR:

  • git daemon
  • git maintenance
  • git am
  • git notes
  • git stripspace
  • git mailinfo
  • git mailsplit
  • Flags for git apply
  • Flags for git mv

Perhaps a lot others are left, feel free to request completions for some common subcommands which are not done yet :)

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@thunder-coding thunder-coding marked this pull request as draft July 12, 2021 04:48
@thunder-coding thunder-coding force-pushed the complete-more-git-commands branch from fdce294 to 3cccf74 Compare July 13, 2021 01:44
@thunder-coding thunder-coding changed the title Add missing completions for some missing git commands Add missing completions for some git commands Jul 13, 2021
@thunder-coding thunder-coding force-pushed the complete-more-git-commands branch 2 times, most recently from 4830488 to 738faf3 Compare July 13, 2021 14:01
@faho
Copy link
Member
faho commented Jul 16, 2021

If I may: I would recommend not trying to do everything in one PR. I've said before that the git completions alone could be a full time job for a few months, and I still believe that.

Find a point you're happy with what's there and submit it for review, instead of adding ALL THE THINGS.

And then write more, on your own branch, and if you have a point that it's okay again, submit that. This makes it so we don't get a notification for every single change.

@thunder-coding
Copy link
Contributor Author
thunder-coding commented Jul 16, 2021

Ok lets merge this for now then. I will be working on them on my fork in the same branch. I will do a PR as soon as everything is complete

@thunder-coding thunder-coding marked this pull request as ready for review July 16, 2021 11:23
@faho
Copy link
Member
faho commented Jul 16, 2021

I will be working on them on my fork in the same branch

Note: Anything you push to the same branch will show up here. So either don't push or make a new branch.

@thunder-coding thunder-coding requested a review from faho July 22, 2021 03:14
@thunder-coding thunder-coding force-pushed the complete-more-git-commands branch from b2b3ebd to 6f52c01 Compare July 22, 2021 07:57
Using `complete -F -c git -n __fish_git_needs_subcommand -a $command -d
$description` causes file completions to be forced on entire git command
which is not a desired result. Morever without the `-F` flag file
completions work just as expected and is useless addition
Copy link
Member
@faho faho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two final typos

@faho faho merged commit c35ffc5 into fish-shell:master Jul 23, 2021
@faho
Copy link
Member
faho commented Jul 23, 2021

Merged, thanks!

@zanchey
Copy link
Member
zanchey commented Jul 23, 2021

Huge effort, amazing!

@thunder-coding thunder-coding deleted the complete-more-git-commands branch July 23, 2021 13:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0