Add completion for climate by Hunsu · Pull Request #3760 · fish-shell/fish-shell

Hunsu · 2017-01-22T10:21:44Z

No description provided.

adtac · 2017-01-22T11:03:49Z

This is climate if anyone is wondering :)

moverest · 2017-01-22T12:05:16Z

share/completions/climate.fish

@@ -0,0 +1,82 @@
+# fish completion for climate


This comment is useless. You should probably write a short description of the tool with a link to the project's man page (or github) instead.

Yeah. While you're at it, ditch the first line. The rest is okay, and I appreciate the link!

moverest · 2017-01-22T12:12:09Z

share/completions/climate.fish

+# Meta
+complete -f -n '__fish_climate_already_has_argument' -c climate -a help -d 'Show help'
+complete -f -n '__fish_climate_already_has_argument' -c climate -a update -d 'Update your climate install'
+complete -f -n '__fish_climate_already_has_argument' -c climate -a uninstall -d 'uninstall your climate installi'


Typo: uninstall your climate installi → Uninstall your climate install.

Maybe use something shorter like Uninstall climate.

moverest · 2017-01-22T12:13:36Z

share/completions/climate.fish

+complete -f -n '__fish_climate_already_has_argument' -c climate -a download-dir -d 'Download dir from server'
+complete -n '__fish_climate_already_has_argument' -c climate -a upload -d 'Upload to server'
+complete -f -n '__fish_climate_already_has_argument' -c climate -a ssh-mount -d 'Mount a remote path'
+complete -n '__fish_climate_already_has_argument' -c climate -a ssh-unmount -d 'nmount a ssh mount'


Unmount a ssh mount?

moverest · 2017-01-22T12:15:01Z

share/completions/climate.fish

+complete -f -c climate -n '__fish_is_git_repository and __fish_climate_already_has_argument' -a user-stats -d 'Calculate total contribution for a user'
+
+# Performance
+complete -f -n '__fish_climate_already_has_argument' -c climate -a overview -d 'Display an performance overviewj'


Display an performance overviewj → Display a performance overview?

moverest · 2017-01-22T12:17:26Z

share/completions/climate.fish

+# Network
+complete -f -n '__fish_climate_already_has_argument' -c climate -a speedtest -d 'Test your network speed'
+complete -f -n '__fish_climate_already_has_argument' -c climate -a local-ip -d 'Retrieve your local ip address'
+complete -f -n '__fish_climate_already_has_argument' -c climate -a is-online -d 'Verify if you''re online'


'Verify if you''re online' → 'Verify if you\'re online'

> echo 'Verify if you''re online' 'Verify if youre online'

Here, fish concatenates the two strings. It's useful when you want to expand variables:

> set var 'Hi there!' > echo 'Did you say "'$var'"?'

Did you say "Hi there!"?

It works like a charm with lists as well:

> set var 'Hi there!' 'Hello world!' > echo 'Did you say "'$var'"?'

Did you say "Hi there!"? Did you say "Hello world!"?

moverest · 2017-01-22T12:20:49Z

share/completions/climate.fish

+
+function __fish_is_git_repository
+    git rev-parse --is-inside-work-tree ^/dev/null >/dev/null
+    return $status


You don't need return $status.

moverest · 2017-01-22T12:25:40Z

share/completions/climate.fish

+
+function __fish_climate_already_has_argument
+    set cmd (commandline -opc)
+    if not set -q cmd[2]


You don't need the if statement with the returns.

Just write: not set -q cmd[2]

moverest · 2017-01-22T12:31:48Z

share/completions/climate.fish

+end
+
+function __fish_climate_already_has_argument
+    set cmd (commandline -opc)


You want a local variable here: set → set -l

moverest · 2017-01-22T13:20:01Z

share/completions/climate.fish

+    return $status
+end
+
+function __fish_climate_already_has_argument


I'm a bit confused by what this function is supposed to do given its name.

__fish_climate_already_has_argument implies that it should return 0 (true) if the command line has an argument but it clearly does the exact opposite. Have I missed something?

I renamed the function to __fish_climate_has_no_argument.

faho · 2017-01-24T10:21:00Z

share/completions/climate.fish

+complete -n '__fish_climate_has_no_argument' -c climate -a ssh-unmount -d 'Unmount a ssh mount'
+
+# git
+complete -f -c climate -n '__fish_is_git_repository and __fish_climate_has_no_argument' -a undo-commit -d 'Undo the latest commit'


This doesn't work because of a missing ";" - __fish_is_git_repository; and. The way it is now, __fish_is_git_repository gets the rest as argument, and __fish_climate_has_no_argument is never executed.

faho · 2017-01-24T10:22:09Z

share/completions/climate.fish

+# but complex combination of Linux commands.
+# The tool can be found at https://github.com/adtac/climate
+
+function __fish_is_git_repository


This might be useful elsewhere, so it should probably be extracted into its own function file. Not a priority though.

It's already implemented in git.fish. Maybe split it?

That one prints the working directory, though completion conditions are implicitly silenced.

Yeah, we should extract it. I can do that later though.

I added __fish_is_git_repository.fish into share/functions folder (also into /usr/share/fish/functions, .config/fish/functions) and I get __fish_is_git_repository: command not found

faho · 2017-01-24T10:22:39Z

share/completions/climate.fish

@@ -0,0 +1,82 @@
+# fish completion for climate


Yeah. While you're at it, ditch the first line. The rest is okay, and I appreciate the link!

faho · 2017-01-24T10:25:36Z

The failing tests here are a result of bad timing - this is based on a broken master. Nothing to worry about here.

moverest · 2017-02-05T14:48:18Z

share/functions/__fish_is_git_repository.fish

@@ -0,0 +1,3 @@
+function __fish_is_git_repository --discription 'Check if current directory is a git repository'


You've made a typo, that's why it's not loading: --description.

fixed the typo but still not loading.

That's strange... it works with me.

Have you tried to do a source path/to/__fish_is_git_repository.fish? Did you put it in ~/.config/fish/functions with the typo fixed to test it?

Now it works after I did source /usr/share/fish/functions/__fish_is_git_repository.fish. Perhaps /usr/share/fish/functions/is only sourced at login ?

It's loaded when you request it for the first time. It sources the first __fish_is_git_repository.fish it finds the directories listed in fish_function_path.

> echo $fish_function_path /home/clement/.config/fish/functions /etc/fish/functions /usr/share/fish/vendor_functions.d /usr/share/fish/functions

My guess is that you have a file named __fish_is_git_repository.fish without the correction in one of the directories listed before /usr/share/fish/functions.

krader1961 · 2017-02-06T03:23:08Z

Thx. Merged as a5e8b81.

Hunsu force-pushed the climate branch from dbed602 to ba23139 Compare January 22, 2017 10:24

This was referenced Jan 22, 2017

Add autocomplete for fish adtac/climate#20

Closed

Fish should not complete git command if we are not in git repository #3761

Closed

moverest reviewed Jan 22, 2017

View reviewed changes

Hunsu force-pushed the climate branch 2 times, most recently from 72b79ed to a501aac Compare January 23, 2017 17:48

faho requested changes Jan 24, 2017

View reviewed changes

faho added completions enhancement labels Jan 24, 2017

faho added this to the next-minor milestone Jan 24, 2017

Hunsu force-pushed the climate branch from a501aac to a29e4ba Compare February 5, 2017 09:32

moverest reviewed Feb 5, 2017

View reviewed changes

Add completion for climate

20c256c

Hunsu force-pushed the climate branch from a29e4ba to 20c256c Compare February 5, 2017 15:46

github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020

		@@ -0,0 +1,3 @@
		function __fish_is_git_repository --discription 'Check if current directory is a git repository'

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants