Closed
Conversation
<
8000
div class="Details-content--hidden mt-2">
It seems kinda silly to not directly do it, but it was explicitly stopped in the code. I'm quite good at deleting that, aren't I? Fixes fish-shell#3016.
Also mentioned in fish-shell#3016.
Contributor
|
A cursory review of the change didn't reveal any obvious bogosities. I patched it into my system and didn't observe any harmful side-effects. So I have no objection to it being merged. Nonetheless, I didn't do a deep dive into the relevant code so I would like someone else with more knowledge of this part of the fish code to give a +1 before it is merged. However, if no one raises any objections in the next six days I recommend merging it. We can always revert or amend the change if it turns out to have problems. |
Member
|
We can try it! |
Contributor
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have to say I don't get why we suppressed autosuggestions in these circumstances. It feels better to allow it, and it doesn't seem to crash or overwhelm my poor little laptop or anything.
It also suppresses after killing, which might be a little more sensible - otherwise it often suggests just what you deleted (which would be a poor man's undo).
Also I quite like that this doesn't include a single new character. All made from free-range recycled bytes.
See #3016.