builtin/test: refactor the Token enum to be more granular#10357
Merged
mqudsi merged 6 commits intofish-shell:masterfrom Mar 16, 2024
Merged
builtin/test: refactor the Token enum to be more granular#10357mqudsi merged 6 commits intofish-shell:masterfrom
mqudsi merged 6 commits intofish-shell:masterfrom
Conversation
mqudsi
approved these changes
Mar 10, 2024
Contributor
There was a problem hiding this comment.
I'm not going to bikeshed about the names, but I approve of the general idea. It's slightly less immediately obvious where to add new functionality but I think on the whole less brittle and more maintainable. Good work.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This feels somewhat ambitious, but shouldn't actually disrupt any of the "interesting" parts of the parsing or evaluation logic.
matches can be exhaustive with no fallback error case, and theTokenInfostruct, with itsflagsfield, becomes redundant.StatPredicateandNumberComparisoncases.tokenfield onCombiningExpressionwas already unnecessary, but these changes made that fact visible, because the only time it was accessed was to validate that it's a combiner token (which would be trivially guaranteed now).I am not attached to any of the names, and am open to alternatives.
TODOs:
(N/A, no user-facing changes)