reader: Use existing search string when opening the history pager#10005
Merged
faho merged 1 commit intofish-shell:masterfrom Sep 9, 2023
Merged
reader: Use existing search string when opening the history pager#10005faho merged 1 commit intofish-shell:masterfrom
faho merged 1 commit intofish-shell:masterfrom
Conversation
I sometimes find myself doing something like this: - Look for a commandline that includes "echo" (as an example) - Type echo, press up a few times - I can't immediately find what I'm looking for - Press ctrl-r to open up the history pager - It uses the current commandline as the search string, so now I'm looking for "echo foobar" This makes it so if the search string already is in use, that's what the history-pager picks as the initial search string.
krobelus
approved these changes
Sep 8, 2023
Contributor
There was a problem hiding this comment.
I think I hit this as well. Great call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sometimes find myself doing something like this:
This makes it so if the search string already is in use, that's what the history-pager picks as the initial search string.
TODOs:
I am entirely fine with shelving this if it gets in the way of anyone's porting. On the other hand it's pretty trivial.