fix(portal): acknowledge WAL change_logs received data #11896
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Just a few minor things, otherwise LGTM
|
@bmanifold Did we want to get this merged to soak test on staging? |
0dd03db to
c142861
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes the PostgreSQL replication acknowledgment logic to properly distinguish between received and flushed WAL (Write-Ahead Log) data in buffered mode, preventing unnecessary KeepAlive message floods from the server.
Changes:
- Updated WAL acknowledgment logic to separately track received vs. persisted data positions
- Added application_name parameters to database connection configs for better monitoring
- Updated Sobelow security skip hashes to reflect config changes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| elixir/lib/portal/replication/connection.ex | Implements proper WAL position tracking by sending separate write/flush LSNs to PostgreSQL |
| elixir/config/config.exs | Adds application_name parameters to all database connections for improved observability |
| elixir/.sobelow-skips | Updates security skip hashes affected by config file modifications |
Yeah, apologies. Was wanting to test if that |
No description provided.