Use makefile targets for all CI tests. #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
samuelkarp
reviewed
Apr 19, 2019
xibz
suggested changes
Apr 19, 2019
samuelkarp
approved these changes
Apr 19, 2019
xibz
approved these changes
Apr 19, 2019
Signed-off-by: Erik Sipsma <sipsma@amazon.com>
The e2e test verifying the shim exits as expected was sometimes failing due to the shim exiting but remaining a zombie. This change adds an init to that image to reap the zombie. Signed-off-by: Erik Sipsma <sipsma@amazon.com>
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
Keep a socket file under testdata/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Erik Sipsma sipsma@amazon.com
This will make it much easier for developers t 10000 o run CI tests locally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.