8000 [WIP] move firebase auth calls to ViewModels by thatfiredev · Pull Request #1459 · firebase/quickstart-android · GitHub
[go: up one dir, main page]
Skip to content

[WIP] move firebase auth calls to ViewModels #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: compose
Choose a base branch
from
Draft

[WIP] move firebase auth calls to ViewModels #1459

wants to merge 9 commits into from

Conversation

thatfiredev
Copy link
Member
@thatfiredev thatfiredev commented Feb 16, 2023 •
edited
Loading

Part of #1457

Some caveats found in the process:

Google Sign in

Ideally, we'd inject the GoogleSignInClient the same way we inject FirebaseAuth into the ViewModel, but some APIs require an Activity, so I've decided to keep GoogleSignInClient on the UI code for now.

@thatfiredev thatfiredev mentioned this pull request Feb 16, 2023
Open
@thatfiredev thatfiredev changed the title [WIP] move firebase auth calls to a dedicated ViewModel [WIP] move firebase auth calls to ViewModels Feb 17, 2023
wallyf1972

This comment was marked as abuse.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wallyf1972 wallyf1972 wallyf1972 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thatfiredev @wallyf1972
0