[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved core lib deps to peer deps for plugins #669

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

pavelgj
Copy link
Collaborator
@pavelgj pavelgj commented Jul 23, 2024

Core libs need to be in peer deps to avoid situations when mismatched plugin and core lib versions in the app package.json cause AsyncLocalStorage and global state issues.

@pavelgj pavelgj requested a review from apascal07 July 23, 2024 00:50
@pavelgj pavelgj merged commit c1f8412 into main Jul 31, 2024
4 checks passed
@pavelgj pavelgj deleted the pj/pluginPeerDeps branch July 31, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants