10BC0 fix(firestore, ios): fix an issue where unlimited cache wasn't properly set on iOS by Lyokone · Pull Request #17412 · firebase/flutterfire · GitHub
[go: up one dir, main page]
Skip to content

fix(firestore, ios): fix an issue where unlimited cache wasn't properly set on iOS #17412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

fix(firestore, ios): fix an issue where unlimited cache wasn't properly set on iOS #17412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .../cloud_firestore/ios/cloud_firestore/Sources/cloud_firestore/FLTFirebaseFirestorePlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,8 @@ - (FIRFirestore *_Nullable)getFIRFirestoreFromAppNameFromPigeon:
if (pigeonApp.settings.persistenceEnabled != nil) {
bool persistEnabled = [pigeonApp.settings.persistenceEnabled boolValue];

// This is the maximum amount of cache allowed. We use the same number on android.
// This now causes an exception: kFIRFirestoreCacheSizeUnlimited
NSNumber *size = @104857600;
// We default to the maximum amount of cache allowed.
NSNumber *size = @(kFIRFirestoreCacheSizeUnlimited);

if (pigeonApp.settings.cacheSizeBytes) {
NSNumber *cacheSizeBytes = pigeonApp.settings.cacheSizeBytes;
Expand Down
5 changes: 2 additions & 3 deletions .../cloud_firestore/ios/cloud_firestore/Sources/cloud_firestore/FLTFirebaseFirestoreReader.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,8 @@ - (FIRFirestoreSettings *)FIRFirestoreSettings {
if (![values[@"persistenceEnabled"] isEqual:[NSNull null]]) {
bool persistEnabled = [((NSNumber *)values[@"persistenceEnabled"]) boolValue];

// This is the maximum amount of cache allowed. We use the same number on android.
// This now causes an exception: kFIRFirestoreCacheSizeUnlimited
NSNumber *size = @104857600;
// We default to the maximum amount of cache allowed.
NSNumber *size = @(kFIRFirestoreCacheSizeUnlimited);

if (![values[@"cacheSizeBytes"] isEqual:[NSNull null]]) {
NSNumber *cacheSizeBytes = ((NSNumber *)values[@"cacheSizeBytes"]);
Expand Down
Loading
0