8000 Fix checkForNode8 issue by samtstern · Pull Request #2945 · firebase/firebase-tools · GitHub
[go: up one dir, main page]
Skip to content

Fix checkForNode8 issue #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2020
Merged

Fix checkForNode8 issue #2945

merged 2 commits into from
Dec 16, 2020

Conversation

samtstern
Copy link
Contributor

Description

Fixes #2944

Scenarios Tested

$ firebase deploy --only functions

=== Deploying to 'fir-dumpster'...

i  deploying functions
i  functions: ensuring required API cloudfunctions.googleapis.com is enabled...
i  functions: ensuring required API cloudbuild.googleapis.com is enabled...
✔  functions: required API cloudfunctions.googleapis.com is enabled
✔  functions: required API cloudbuild.googleapis.com is enabled
i  functions: preparing functions directory for uploading...
i  functions: packaged functions (24.53 KB) for uploading
✔  functions: functions folder uploaded successfully
i  functions: creating Node.js 12 function helloWorld(us-central1)...

The following functions are found in your project but do not exist in your local source code:
        createToken(us-central1)
        helloworld(us-central1)
        onTestUpdate(us-central1)
        verifyToken(us-central1)

If you are renaming a function or changing its region, it is recommended that you create the new function first before deleting the old one to prevent event loss. For more info, visit https://firebase.google.com/docs/functions/manage-functions#modify

? Would you like to proceed with deletion? Selecting no will continue the res
t of the deployments. No
i  functions: continuing with other deployments.
✔  functions[helloWorld(us-central1)]: Successful create operation. 
Function URL (helloWorld): https://us-central1-fir-dumpster.cloudfunctions.net/helloWorld

✔  Deploy complete!

Project Console: https://console.firebase.google.com/project/fir-dumpster/overview

Sample Commands

@samtstern samtstern requested a review from bkendall December 16, 2020 10:31
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Dec 16, 2020
@samtstern samtstern mentioned this pull request Dec 16, 2020
Closed
@samtstern samtstern merged commit 482836e into master Dec 16, 2020
@rajprashanthr
Copy link

Awesome speed in fixing the issue . Thanks a lot

@MichaelRShelton
Copy link

Thank you for fixing this so quickly!

@bkendall bkendall deleted the ss-fix-2944 branch August 4, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall bkendall approved these changes

Assignees

@bkendall bkendall

Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checkForNode8 is not a function
4 participants
@samtstern @rajprashanthr @MichaelRShelton @bkendall
0