[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved validateArgs to core SDK #8370

Merged
merged 21 commits into from
Jul 30, 2024
Merged

Moved validateArgs to core SDK #8370

merged 21 commits into from
Jul 30, 2024

Conversation

maneesht
Copy link
Contributor

No description provided.

@maneesht maneesht requested review from a team as code owners July 16, 2024 23:41
Copy link
changeset-bot bot commented Jul 16, 2024

⚠️ No Changeset found

Latest commit: 70c141f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maneesht maneesht changed the base branch from master to dataconnect July 16, 2024 23:41
@maneesht maneesht removed request for a team July 16, 2024 23:41
@google-oss-bot
Copy link
Contributor
google-oss-bot commented Jul 16, 2024

Size Report 1

Affected Products

  • @firebase/data-connect

    TypeBase (f48864c)Merge (e17410d)Diff
    browser17.4 kB17.8 kB+398 B (+2.3%)
    esm519.6 kB20.0 kB+398 B (+2.0%)
    main21.6 kB22.1 kB+476 B (+2.2%)
    module17.4 kB17.8 kB+398 B (+2.3%)
  • firebase

    TypeBase (f48864c)Merge (e17410d)Diff
    firebase-data-connect.js14.9 kB15.1 kB+197 B (+1.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/f4coAwBQrt.html

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Jul 17, 2024

Size Analysis Report 1

Affected Products

  • @firebase/data-connect

    • validateArgs

      Size

      TypeBase (f48864c)Merge (e17410d)Diff
      size?10.9 kB? (?)
      size-with-ext-deps?36.0 kB? (?)

      Dependency

      TypeBase (f48864c)Merge (e17410d)Diff
      functions?

      17 dependencies

      addToken
      compareDates
      dcFetch
      getDataConnect
      getGoogApiClientValue
      getMessage
      getRefSerializer
      logDebug
      logError
      parseOptions
      registerDataConnect
      setEncoder
      setIfNotExists
      setSDKVersion
      urlBuilder
      validateArgs
      validateDCOptions

      ?
      classes?

      DataConnect
      DataConnectError
      FirebaseAuthProvider
      MutationManager
      QueryManager
      RESTTransport

      ?
      variables?

      11 dependencies

      Code
      FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR
      QUERY_STR
      SDK_VERSION
      SOURCE_CACHE
      SOURCE_SERVER
      connectFetch
      encoderImpl
      logger
      name
      version

      ?
      enums??

      External Dependency

      ModuleBase (f48864c)Merge (e17410d)Diff
      @firebase/app?

      SDK_VERSION
      _getProvider
      _registerComponent
      _removeServiceInstance
      getApp
      registerVersion

      ?
      @firebase/component?

      Component

      ?
      @firebase/logger?

      Logger

      ?
      @firebase/util?

      FirebaseError

      ?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oVf4ooNHut.html

@maneesht maneesht merged commit 6aae5f5 into dataconnect Jul 30, 2024
34 of 40 checks passed
@maneesht maneesht deleted the mtewani/add-validateargs branch July 30, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants