Fix isSafari() throwing on React Native (fixes #7962) #7963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d94a69b The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dconeybe
reviewed
Jan 19, 2024
dconeybe
approved these changes
Jan 19, 2024
dconeybe
requested changes
Jan 19, 2024
DellaBitta
approved these changes
Jan 19, 2024
dconeybe
approved these changes
Jan 19, 2024
dconeybe
added a commit
that referenced
this pull request
Jan 19, 2024
|
Looks like GitHub Actions fails miserably when run in a PR from an external contributor. I've opened #7965 to run them under my name. We can use those results to gate this PR's merge then just force-merge this one. |
Co-authored-by: dconeybe <dconeybe@google.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7929 some logic was added to Firestore to check for the browser being Safari. This new check for
isSafari()unexpectedly threw an exception in React Native. This PR fixes the exception by explicitly checking for an object not beingundefinedbefore using it.Fixes #7962