8000 Firestore: update firestore-types with breaking API changes for FirestoreDataConverter by dconeybe · Pull Request #7423 · firebase/firebase-js-sdk · GitHub
[go: up one dir, main page]
Skip to content

Firestore: update firestore-types with breaking API changes for FirestoreDataConverter #7423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 6, 2023
Merged

Firestore: update firestore-types with breaking API changes for FirestoreDataConverter #7423

merged 5 commits into from
Jul 6, 2023

Conversation

dconeybe
Copy link
Contributor
@dconeybe dconeybe commented Jul 6, 2023 •
edited
Loading

Update index.d.ts from the firestore-types package for the FirestoreDataConverter breaking API changes from #7310.

This fixes ~29 build errors that anyone using the firestore-compat library would get, that look like this:

node_modules/@firebase/firestore-compat/dist/src/index.d.ts:54:80 - error TS2707: Generic type 'CollectionReference<T>' requires between 0 and 1 type arguments.

54     function addDoc<AppModelType, DbModelType extends DocumentData>(reference: types.CollectionReference<AppModelType, DbModelType>, data: WithFieldValue<AppModelType>): Promise<DocumentReference<AppModelType, DbModelType>>;
                                                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I tested this change by creating a new npm project and running npm install firebase@next and running this little test app: https://gist.github.com/dconeybe/cf113e198fe0e52283f0251fa0ff6899

Googlers see b/290216686 for details.

@dconeybe dconeybe self-assigned this Jul 6, 2023
@changeset-bot
Copy link
changeset-bot bot commented Jul 6, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: f35f998

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/firestore-types Major
firebase Major
@firebase/firestore-compat Patch
@firebase/rules-unit-testing Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor
google-oss-bot E880 commented Jul 6, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (f3067f7) and merge commit (b1823ca).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qt4sVAB53C.html

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Jul 6, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (1,841,654 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RQx3IeInaA.html

@dconeybe dconeybe mentioned this pull request Jul 6, 2023
Merged
@dconeybe dconeybe marked this pull request as ready for review July 6, 2023 21:13
@dconeybe dconeybe requested review from a team as code owners July 6, 2023 21:13
@dconeybe dconeybe merged commit 47860fe into master Jul 6, 2023
@dconeybe dconeybe deleted the dconeybe/UpdateDataTypeFix3CompatAndTypesFix branch July 6, 2023 22:29
@google-oss-bot google-oss-bot mentioned this pull request Jul 6, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dconeybe @google-oss-bot @ehsannas @hsubox76
0