8000 Update public api signature for setUserId to reflect internal functions by dwyfrequency · Pull Request #6671 · firebase/firebase-js-sdk · GitHub
[go: up one dir, main page]
Skip to content

Update public api signature for setUserId to reflect internal functions #6671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2022
Merged

Update public api signature for setUserId to reflect internal functions #6671

merged 3 commits into from
Oct 10, 2022

Conversation

dwyfrequency
Copy link
Contributor
@dwyfrequency dwyfrequency commented Oct 10, 2022 •
edited
Loading

Allow users to pass in null value to public setUserId per internal implementations

#6592

@changeset-bot
Copy link
changeset-bot bot commented Oct 10, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: bb834ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/analytics Patch
@firebase/analytics-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Oct 10, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (29d0340)Merge (cee7ee7)Diff
    browser20.1 kB20.2 kB+59 B (+0.3%)
    esm524.7 kB24.8 kB+59 B (+0.2%)
    main26.0 kB26.1 kB+59 B (+0.2%)
    module20.1 kB20.2 kB+59 B (+0.3%)

  • bundle

    TypeBase (29d0340)Merge (cee7ee7)Diff
    analytics (logEvent)42.9 kB42.9 kB+21 B (+0.0%)

  • firebase

    TypeBase (29d0340)Merge (cee7ee7)Diff
    firebase-analytics-compat.js25.8 kB25.8 kB+21 B (+0.1%)
    firebase-analytics.js24.9 kB24.9 kB+21 B (+0.1%)
    firebase-compat.js740 kB740 kB+21 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wVfkijb21Q.html

@dwyfrequency dwyfrequency marked this pull request as ready for review October 10, 2022 18:20
@google-oss-bot
Copy link
Contributor
google-oss-bot commented Oct 10, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/analytics

    • getAnalytics

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.98 kB10.0 kB+21 B (+0.2%)
      size-with-ext-deps42.8 kB42.8 kB+21 B (+0.0%)

    • initializeAnalytics

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.88 kB9.90 kB+21 B (+0.2%)
      size-with-ext-deps36.0 kB36.1 kB+21 B (+0.1%)

    • isSupported

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.77 kB9.79 kB+21 B (+0.2%)
      size-with-ext-deps35.6 kB35.6 kB+21 B (+0.1%)

    • logEvent

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.63 kB9.65 kB+21 B (+0.2%)
      size-with-ext-deps35.5 kB35.5 kB+21 B (+0.1%)

    • setAnalyticsCollectionEnabled

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.79 kB9.81 kB+21 B (+0.2%)
      size-with-ext-deps35.6 kB35.7 kB+21 B (+0.1%)

    • setConsent

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.76 kB9.78 kB+21 B (+0.2%)
      size-with-ext-deps35.6 kB35.6 kB+21 B (+0.1%)

    • setCurrentScreen

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.87 kB9.89 kB+21 B (+0.2%)
      size-with-ext-deps35.7 kB35.7 kB+21 B (+0.1%)

    • setDefaultEventParameters

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.74 kB9.77 kB+21 B (+0.2%)
      size-with-ext-deps35.6 kB35.6 kB+21 B (+0.1%)

    • setUserId

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.86 kB9.88 kB+21 B (+0.2%)
      size-with-ext-deps35.7 kB35.7 kB+21 B (+0.1%)

    • setUserProperties

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.94 kB9.96 kB+21 B (+0.2%)
      size-with-ext-deps35.8 kB35.8 kB+21 B (+0.1%)

    • settings

      Size

      TypeBase (29d0340)Merge (cee7ee7)Diff
      size9.75 kB9.77 kB+21 B (+0.2%)
      size-with-ext-deps35.6 kB35.6 kB+21 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uXwNOXeaNE.html

@github-actions github-actions bot added the doc-changes PRs that affect docs label Oct 10, 2022
@dwyfrequency dwyfrequency merged commit 03d1fab into master Oct 10, 2022
@dwyfrequency dwyfrequency deleted the jd-analytics-setuserid-6592 branch October 10, 2022 22:58
@google-oss-bot google-oss-bot mentioned this pull request Oct 12, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

No one assigned

Labels

doc-changes PRs that affect docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwyfrequency @google-oss-bot @hsubox76
0