8000 Unit test cases for sign-in flow by bhparijat · Pull Request #6640 · firebase/firebase-js-sdk · GitHub
[go: up one dir, main page]
Skip to content

Unit test cases for sign-in flow #6640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2022
Merged

Unit test cases for sign-in flow #6640

merged 2 commits into from
Oct 14, 2022

Conversation

bhparijat
Copy link
Contributor

This PR contains code implementation for adding unit test cases for sigin-flow

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link
changeset-bot bot commented Sep 29, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4ebae0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bhparijat bhparijat changed the base branch from master to mfa-totp September 29, 2022 22:27
@bhparijat bhparijat changed the base branch from mfa-totp to parijat-totp-signin September 29, 2022 22:27
@bhparijat bhparijat changed the base branch from parijat-totp-signin to mfa-totp September 29, 2022 22:27
bhparijat
bhparijat commented 8000 Sep 29, 2022
View reviewed changes
@google-oss-bot
Copy link
Contributor
google-oss-bot commented Sep 29, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (84f4161) and merge commit (3214461).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/stoftPLiqS.html

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Sep 29, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (84f4161) and merge commit (3214461).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NwDPVWfnDb.html

@github-actions github-actions bot added the doc-changes PRs that affect docs label Sep 29, 2022
prameshj
prameshj reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor
@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could combine this with #6626 since the unit test changes aren't that big.

@bhparijat bhparijat force-pushed the parijat-totp-signin-unit-testing branch from db24b62 to 7799fb1 Compare October 11, 2022 21:08
@bhparijat bhparijat changed the base branch from mfa-totp to parijat-totp-signin October 11, 2022 21:12
@bhparijat bhparijat changed the base branch from parijat-totp-signin to mfa-totp October 11, 2022 21:13
@bhparijat bhparijat changed the base branch from mfa-totp to parijat-totp-signin October 11, 2022 21:42
@bhparijat bhparijat force-pushed the parijat-totp-signin branch 2 times, most recently from a6f495d to d6618b3 Compare October 11, 2022 22:09
sam-gc
sam-gc reviewed Oct 11, 2022
View reviewed changes
@bhparijat bhparijat force-pushed the parijat-totp-signin-unit-testing branch from 6626fb0 to f712d49 Compare October 12, 2022 06:03
@bhparijat bhparijat force-pushed the parijat-totp-signin-unit-testing branch from 75ecdfa to ce222f1 Compare October 12, 2022 07:40
renkelvin
renkelvin reviewed Oct 12, 2022
View reviewed changes
@bhparijat bhparijat requested review from renkelvin and sam-gc October 12, 2022 17:28
@sam-gc sam-gc mentioned this pull request Oct 12, 2022
Merged
@bhparijat bhparijat force-pushed the parijat-totp-signin-unit-testing branch 2 times, most recently from c1e4484 to 91d1b2a Compare October 12, 2022 21:35
@bhparijat bhparijat force-pushed the parijat-totp-signin branch 2 times, most recently from 32b2805 to 599348b Compare October 13, 2022 16:56
Base automatically changed from parijat-totp-signin to mfa-totp October 13, 2022 19:05
@bhparijat bhparijat force-pushed the parijat-totp-signin-unit-testing branch 2 times, most recently from 2049369 to 45c8254 Compare October 13, 2022 19:31
@bhparijat bhparijat force-pushed the parijat-totp-signin-unit-testing branch from 45c8254 to 4ebae0a Compare October 13, 2022 19:38
@bhparijat bhparijat merged commit d8c26f6 into mfa-totp Oct 14, 2022
@bhparijat bhparijat deleted the parijat-totp-signin-unit-testing branch October 14, 2022 17:35
@firebase firebase locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@prameshj prameshj prameshj left review comments

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner 8000

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

@egilmorez egilmorez Awaiting requested review from egilmorez

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@jposuna jposuna Awaiting requested review from jposuna

@yoyomyo yoyomyo Awaiting requested review from yoyomyo

@zwu52 zwu52 Awaiting requested review from zwu52

@maneesht maneesht Awaiting requested review from maneesht

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

@jsdt jsdt Awaiting requested review from jsdt

@jmwski jmwski Awaiting requested review from jmwski

+1 more reviewer

@renkelvin renkelvin renkelvin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@renkelvin renkelvin

@sam-gc sam-gc

@egilmorez egilmorez

@prameshj prameshj

Labels

doc-changes PRs that affect docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bhparijat @google-oss-bot @renkelvin @sam-gc @prameshj @egilmorez
0