8000 Fix Issue 474 by jshcrowthe · Pull Request #599 · firebase/firebase-js-sdk · GitHub
[go: up one dir, main page]
Skip to content

Fix Issue 474 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2018
Merged

Fix Issue 474 #599

merged 1 commit into from
Mar 28, 2018

Conversation

jshcrowthe
Copy link
Contributor

Removes the following unneeded block:

declare module `firebase` {}

This file is referenced from the package.json and is automatically assigned to the firebase name.

Fixes #474

@jshcrowthe jshcrowthe requested a review from hiranya911 March 28, 2018 20:25
hiranya911
hiranya911 approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor
@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jshcrowthe jshcrowthe merged commit 3259004 into master Mar 28, 2018
@jshcrowthe jshcrowthe deleted the fix-474 branch March 28, 2018 20:31
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jshcrowthe jshcrowthe

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate identifier errors when compiling a project which links a module
3 participants
@jshcrowthe @hiranya911 @google-oss-bot
0