8000 [Auth] Add tabindex=-1 to iframe to fix issue with aria-hidden by sam-gc · Pull Request #5700 · firebase/firebase-js-sdk · GitHub
[go: up one dir, main page]
Skip to content

[Auth] Add tabindex=-1 to iframe to fix issue with aria-hidden #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2021
Merged

[Auth] Add tabindex=-1 to iframe to fix issue with aria-hidden #5700

merged 2 commits into from
Nov 4, 2021

Conversation

sam-gc
Copy link
Contributor
@sam-gc sam-gc commented Nov 4, 2021

Fixes #5631

This is a follow-up to https://github.com/firebase/firebase-js-sdk/pull/5633/files. There was still an issue with lighthouse until we add tabindex=-1 to the iframe as well

@sam-gc sam-gc requested a review from avolkovi as a code owner November 4, 2021 20:52
@changeset-bot
Copy link
changeset-bot bot commented Nov 4, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: b8f3172

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Nov 4, 2021
@sam-gc sam-gc requested a review from egilmorez as a code owner November 4, 2021 20:53
yuchenshi
yuchenshi approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member
@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for caring about accessibility!

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Nov 4, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/auth/internal

    Type Base (6ee947d) Head (511f887) Diff
    browser 163 kB 163 kB +14 B (+0.0%)
    esm5 211 kB 211 kB +14 B (+0.0%)
    module 163 kB 163 kB +14 B (+0.0%)

  • firebase

    Type Base (6ee947d) Head (511f887) Diff
    firebase-auth-compat.js 123 kB 123 kB +14 B (+0.0%)
    firebase-auth.js 410 kB 410 kB +21 B (+0.0%)
    firebase-compat.js 749 kB 749 kB +14 B (+0.0%)

Test Logs
8000

@sam-gc sam-gc merged commit dbd54f7 into master Nov 4, 2021
@sam-gc sam-gc deleted the sam-gc/lighthouse branch November 4, 2021 21:18
@google-oss-bot
Copy link
Contributor
google-oss-bot commented Nov 4, 2021 •
edited
Loading

Size Analysis Report

Affected Products

  • @firebase/auth

    • getAuth

      Size Table

      TypeBase (6ee947d)Head (511f887)Diff
      size
      61.8 kB
      61.8 kB
      +14 B (+0.0%)
      size-with-ext-deps
      74.3 kB
      74.3 kB
      +14 B (+0.0%)

    • browserPopupRedirectResolver

      Size Table

      TypeBase (6ee947d)Head (511f887)Diff
      size
      54.1 kB
      54.1 kB
      +14 B (+0.0%)
      size-with-ext-deps
      66.1 kB
      66.2 kB
      +14 B (+0.0%)

@google-oss-bot google-oss-bot mentioned this pull request Nov 8, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lisajian lisajian lisajian approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@lisajian lisajian

@yuchenshi yuchenshi

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lighthouse Report Issue with auth iframe

4 participants

@sam-gc @google-oss-bot @lisajian @yuchenshi
0