10BC0 Return Firestore-Compat types from QuerySnapshot.docs by schmidt-sebastian · Pull Request #4136 · firebase/firebase-js-sdk · GitHub
[go: up one dir, main page]
Skip to content

Return Firestore-Compat types from QuerySnapshot.docs #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 30, 2020
Merged

Return Firestore-Compat types from QuerySnapshot.docs #4136

merged 6 commits into from
Nov 30, 2020

Conversation

schmidt-sebastian
Copy link
Contributor
@schmidt-sebastian schmidt-sebastian commented Nov 30, 2020 •
edited
Loading

This fixes a bug where the Firestore Classic SDK leaks the firestore-exp types in QuerySnapshots. We need to use the Firestore Classic's UserDataWriter (similar to what we already do in DoucmentSnapshot.get()).

Fixes #4125, #4134

@changeset-bot
Copy link
changeset-bot bot commented Nov 30, 2020 •
edited
Loading

🦋 Changeset detected

Latest commit: bf9b50c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Nov 30, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (068edfa) and head commit (13bbf16).

Test Logs

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/querysnapshotfix branch from 00b92d8 to 3bae066 Compare November 30, 2020 18:44
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/querysnapshotfix branch from 3bae066 to 7c927b0 Compare November 30, 2020 19:28
@schmidt-sebastian schmidt-sebastian merged commit 8993f16 into master Nov 30, 2020
@google-oss-bot google-oss-bot mentioned this pull request Dec 2, 2020
Merged
@schmidt-sebastian schmidt-sebastian mentioned this pull request Dec 22, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Field type reference in QueryDocumentSnapshot is not an instance of DocumentReference
3 participants
@schmidt-sebastian @google-oss-bot @dconeybe
0