8000 Fixed analyze issues introduced in Xcode 12.5 by paulb777 · Pull Request #8210 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

Fixed analyze issues introduced in Xcode 12.5 #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2021
Merged

Fixed analyze issues introduced in Xcode 12.5 #8210

merged 3 commits into from
Jun 8, 2021

Conversation

paulb777
Copy link
Member
@paulb777 paulb777 commented Jun 7, 2021

Screen Shot 2021-06-07 at 7 37 01 AM
Screen Shot 2021-06-07 at 7 37 52 AM

@google-cla google-cla bot added the cla: yes label Jun 7, 2021
@google-oss-bot
Copy link

Coverage Report

Affected SDKs

No changes between base commit (ac7bcdc) and head commit (d46cc15).

Test Logs

@paulb777 paulb777 requested a review from rosalyntan June 7, 2021 16:26
@paulb777 paulb777 enabled auto-merge (squash) June 7, 2021 18:34
@paulb777 paulb777 mentioned this pull request Jun 8, 2021
Merged
maksymmalyhin
maksymmalyhin approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor
@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m
@return The reCAPTCHA token if successful.
*/
- (NSString *)reCAPTCHATokenForURL:(NSURL *)URL error:(NSError **)error {
- (nullable NSString *)reCAPTCHATokenForURL:(NSURL *)URL error:(NSError **_Nonnull)error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, it will be safer to check for NULL because there might be cases when compiler and analyzer may not catch nullability issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error pointer for the one call is allocated at https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m#L667

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for checking. I sill think it is safer to assume nullable pointer to make it less probable to accidentally introduce a crash in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #8214

@paulb777 paulb777 merged commit 1402fc3 into master Jun 8, 2021
@paulb777 paulb777 deleted the pb-analyze-auth branch June 8, 2021 14:10
@firebase firebase locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rosalyntan rosalyntan Awaiting requested review from rosalyntan

1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: auth cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @google-oss-bot @maksymmalyhin
0