8000 Change log message to reference FID instead of IID by christibbs · Pull Request #5680 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

Change log message to reference FID instead of IID #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2020
Merged

Change log message to reference FID instead of IID #5680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
411b54e
Change log message to reference FID instead of IID
christibbs May 26, 2020
c1ec371
Add CHANGELOG entry
christibbs May 26, 2020
357f371
Slight changelog tweak
christibbs May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseInAppMessaging/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 2020-06-02 -- v0.20.2
- [fixed] Fixed log message for in-app messaging test on device flow (#5680).

# 2020-05-19 -- v0.20.1
- [fixed] Fixed an issue where clicks were counted for messages with no action URL (#5564).

Expand Down
12 changes: 7 additions & 5 deletions FirebaseInAppMessaging/Sources/Runtime/FIRIAMRuntimeManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,18 +385,20 @@ - (void)internalStartRuntimeWithSDKSettings:(FIRIAMSDKSettings *)settings {
NSString
*_Nullable FISToken,
NSError *_Nullable error) {
// Always dump the instance
// id into log on startup to
// help developers to find it
// for their app instance.
// Always dump the
// installation ID into log
// on startup to help
// developers to find it for
// their app instance.
FIRLogDebug(
kFIRLoggerInAppMessaging,
@"I-IAM180017",
@"Starting "
@"InAppMessaging "
@"runtime "
@"with "
"Instance ID %@",
"Firebase Installation "
"ID %@",
FID);
}];

Expand Down
0