E546 correct timezone proto key by charlotteliang · Pull Request #3132 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]

Skip to content

Conversation

charlotteliang
Copy link
Contributor

The timezone proto key passed in is in wrong format.

Copy link
Contributor
@christibbs christibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Travis.

Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis was good except for a flake.

@charlotteliang charlotteliang merged commit f0f9d70 into master Jun 7, 2019
@charlotteliang charlotteliang deleted the fcm-timezone branch June 7, 2019 19:29
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0