Remove FIRAnalyticsConfiguration from Public header. #2728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't removed it entirely yet because we need to make changes within Analytics to verify that the global data collection switch is still honored and tested well. This can wait until after the breaking change because the header and code will be internal after this change.
paulb777
approved these changes
Apr 5, 2019
paulb777
approved these changes
Apr 8, 2019
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Remove FIRAnalyticsConfiguration from Public header. We haven't removed it entirely yet because we need to make changes within Analytics to verify that the global data collection switch is still honored and tested well. This can wait until after the breaking change because the header and code will be internal after this change. * Fixed incomplete comment. * Remove self importing header.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.