8000 fix(ml): Re-generate MLModelDownloader proto by ncooke3 · Pull Request #15239 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

fix(ml): Re-generate MLModelDownloader proto #15239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

fix(ml): Re-generate MLModelDownloader proto #15239

merged 1 commit into from
Aug 21, 2025

Conversation

ncooke3
Copy link
Member
@ncooke3 ncooke3 commented Aug 21, 2025

Failing workflows:

swift-protobug 1.31.0 was released a few days and included a new deprecation: apple/swift-protobuf@37efaf6. MLModelDownloader picked up this new version and surfaces warnings in the lib/spec lints.

@gemini-code-assist Gemini Code Assist
Copy link
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@google-oss-bot
Copy link
1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3 ncooke3 merged commit 52ae69a into main Aug 21, 2025
48 checks passed
@ncooke3
Copy link
Member Author
ncooke3 commented Aug 21, 2025 
~ brew install swift-protobuf
~ firebase-ios-sdk (main) % cd FirebaseMLModelDownloader/Sources/proto 
~ proto (main) % protoc --swift_out=. my.proto

@github-actions github-actions bot mentioned this pull request Sep 16, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Sep 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @google-oss-bot @paulb777
0