10BC0 [Firebase AI] Deprecate `CountTokensResponse.totalBillableCharacters` by andrewheard · Pull Request #14998 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

[Firebase AI] Deprecate CountTokensResponse.totalBillableCharacters #14998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2025
Merged

[Firebase AI] Deprecate CountTokensResponse.totalBillableCharacters #14998

merged 6 commits into from
Jun 17, 2025

Conversation

andrewheard
Copy link
Contributor
@andrewheard andrewheard commented Jun 17, 2025 •
edited
Loading

Deprecated the totalBillableCharacters property on CountTokensResponse the concept of billable characters does not apply to Gemini 2.0 series models and newer. Billing is based on the token count returned in totalTokens. This property will always be nil for the Gemini Developer API backend. While it may be present for the Vertex AI backend, it should not be used for billing calculations. Resolves #14934.

@gemini-code-assist Gemini Code Assist
Copy link
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@andrewheard andrewheard marked this pull request as ready for review June 17, 2025 22:44
@andrewheard andrewheard requested a review from paulb777 June 17, 2025 22:44
paulb777
paulb777 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

AB11
@andrewheard andrewheard merged commit dbf9d01 into main Jun 17, 2025
60 checks passed
@andrewheard andrewheard deleted the ah/firebaseai-billablecharacters branch June 17, 2025 23:09
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Merged
cherylEnkidu pushed a commit that referenced this pull request Jun 30, 2025
@andrewheard @cherylEnkidu
[Firebase AI] Deprecate CountTokensResponse.totalBillableCharacters (…
3879094 
…#14998)
@firebase firebase locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: firebaseai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase AI: Billable Characters is nil when using backend as GoogleAI
3 participants
@andrewheard @paulb777 @google-oss-bot
0