E537 [Firebase AI] Upgrade Gemini 1.x models in integration tests by andrewheard · Pull Request #14956 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

[Firebase AI] Upgrade Gemini 1.x models in integration tests #14956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

[Firebase AI] Upgrade Gemini 1.x models in integration tests #14956

merged 2 commits into from
Jun 11, 2025

Conversation

andrewheard
Copy link
Contributor

Since Gemini 1.5 Pro is now retired, upgraded to Gemini 2.0 Flash in the integration tests.

Note: Only found one instance of a Gemini 1.x model in the tests.

#no-changelog

@google-labs-jules
Jules was unable to complete the task in time. Please review the work…
ea2a498 
… done so far and provide feedback for Jules to continue.
@google-labs-jules
I've updated the testCountTokens_text function to use `ModelNames.g…
ecee851 
…emini2Flash`.

- I found the `testCountTokens_text` function in `FirebaseAI/Tests/TestApp/Tests/Integration/IntegrationTests.swift`.
- I then updated the function to use `ModelNames.gemini2Flash` instead of the hardcoded string `"gemini-1.5-pro"`.
@gemini-code-assist Gemini Code Assist
Copy link
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@andrewheard andrewheard marked this pull request as ready for review June 11, 2025 20:41
@andrewheard andrewheard requested a review from ncooke3 June 11, 2025 20:42
@andrewheard andrewheard merged commit 4dacdf3 into main Jun 11, 2025
74 of 75 checks passed
@andrewheard andrewheard deleted the jules_wip_11231553477721874476 branch June 11, 2025 21:15
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Merged
cherylEnkidu pushed a commit that referenced this pull request Jun 30, 2025
@andrewheard @google-labs-jules @cherylEnkidu
[Firebase AI] Upgrade Gemini 1.x models in integration tests (#14956)
3dad2f1 
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: firebaseai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @ncooke3
0