E53D [Vertex AI] Fix `countTokens` integration tests by andrewheard · Pull Request #14673 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

[Vertex AI] Fix countTokens integration tests #14673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

[Vertex AI] Fix countTokens integration tests #14673

merged 1 commit into from
Apr 8, 2025

Conversation

andrewheard
Copy link
Contributor
  • Fixed the isEqual(to:accuracy:) method in the Numeric extension
    • This allowed the test to fail when token counts changed by 1
    • Updated the generateContentEnum test with the count from the current tokenizer
  • Migrated the countTokens_jsonSchema test to Sw FF8 ift Testing and parameterized to run in all supported environments

#no-changelog

FBC8
@gemini-code-assist Gemini Code Assist
Copy link
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@andrewheard andrewheard marked this pull request as ready for review April 8, 2025 03:11
@andrewheard andrewheard requested a review from paulb777 April 8, 2025 03:11
@andrewheard andrewheard merged commit a95ddb1 into main Apr 8, 2025
36 checks passed
@andrewheard andrewheard deleted the ah/vertex-count-integration branch April 8, 2025 14:25
@paulb777 paulb777 mentioned this pull request Apr 8, 2025
Closed
ncooke3 pushed a commit that referenced this pull request Apr 9, 2025
@andrewheard @ncooke3
[Vertex AI] Fix countTokens integration tests (#14673)
79e2f6c
@github-actions github-actions bot mentioned this pull request Apr 22, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: firebaseai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777
0