8000 [Infra] Update to clang-format@20 and apply updated styling. by ncooke3 · Pull Request #14531 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

[Infra] Update to clang-format@20 and apply updated styling. #14531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2025
Merged

[Infra] Update to clang-format@20 and apply updated styling. #14531

merged 2 commits into from
Mar 5, 2025

Conversation

ncooke3
Copy link
Member
@ncooke3 ncooke3 commented Mar 5, 2025 •
edited
Loading

check passed

google-labs-jules bot and others added 2 commits March 5, 2025 15:20
@google-labs-jules
Update to clang-format@20 and apply updated styling.
1abe627 
This commit updates the repository to use clang-format version 20.
The scripts clang-format not found, install with 'brew install clang-format' and python --version: Python 3.12.3 were updated to use this version.
Also, the  file was updated.
The script clang-format not found, install with 'brew install clang-format' was run, but due to the unavailability of the test environment, I could not check if the changes introduced regressions.
@ncooke3
Remove random newline
319403f
@ncooke3 ncooke3 requested review from andrewheard and paulb777 March 5, 2025 16:00
andrewheard
andrewheard approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor
@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ncooke3 ncooke3 enabled auto-merge (squash) March 5, 2025 16:07
@ncooke3 ncooke3 disabled auto-merge March 5, 2025 16:07
@ncooke3 ncooke3 merged commit 2ea79ab into main Mar 5, 2025
35 checks passed
@ncooke3 ncooke3 deleted the update-clang-format branch March 5, 2025 16:08
This was referenced Mar 5, 2025
Merged
Merged
@github-actions github-actions bot mentioned this pull request Mar 18, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @andrewheard
0