8000 Fix zip build break by paulb777 · Pull Request #11344 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

Fix zip build break #11344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2023
Merged

Fix zip build break #11344

merged 3 commits into from
May 29, 2023

Conversation

paulb777
Copy link
Member

#11289 used Swift language functionality not available in Xcode 13 causing the zip build to break.

Fix #11305

@paulb777 paulb777 enabled auto-merge (squash) May 28, 2023 14:07
@paulb777 paulb777 requested a review from andrewheard May 29, 2023 14:20
andrewheard
andrewheard approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor
@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul! And sorry that you were fixing this on the long weekend :(

@paulb777 paulb777 merged commit 23836ff into master May 29, 2023
@paulb777 paulb777 deleted the pb-xc13-build-break branch May 29, 2023 14:24
@firebase firebase locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
api: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
3 participants
@paulb777 @andrewheard @google-oss-bot
0