10BC0 Add getLimitedUseToken method in FIRAppCheckInterop by aiwenisevan · Pull Request #11233 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

Add getLimitedUseToken method in FIRAppCheckInterop #11233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add getLimitedUseToken method in FIRAppCheckInterop #11233

wants to merge 4 commits into from

Conversation

aiwenisevan
Copy link
Contributor
@aiwenisevan aiwenisevan commented May 5, 2023 •
edited
Loading

Discussion

Testing

  • Passed all Unit Tests

@google-oss-bot
Copy link
1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

andrewheard added 2 commits May 8, 2023 13:15
@andrewheard
Formatting fixes
4725fa0 
Ran scripts/style.sh
@andrewheard
More formatting fixes
d1dceb2 
Ran `./scripts/style.sh SharedTestUtilities`
@aiwenisevan aiwenisevan changed the title draft a pr to add limitedUseToken in interop Add getLimitedUseToken method in FIRAppCheckInterop May 8, 2023
@aiwenisevan aiwenisevan requested review from andrewheard and ncooke3 May 8, 2023 19:27
@aiwenisevan aiwenisevan marked this pull request as ready for review May 8, 2023 19:27
andrewheard
andrewheard reviewed May 8, 2023
View reviewed changes
Copy link
Contributor
@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple super nitpicky comments.

ncooke3
ncooke3 approved these changes May 8, 2023
View reviewed changes
Copy link
Member
@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remember to raise Function's dependency on AppCheckInterop when the Functions PR is opened. It might not be a bad idea to leave this PR open as a reminder.

@andrewheard
Copy link
Contributor

@ncooke3 @paulb777 Should we update the podspecs for Auth, Functions and Storage to specify 'FirebaseAppCheckInterop', '~> 10.10' in this PR or wait until this new method is used?

@ncooke3
Copy link
Member
ncooke3 commented May 12, 2023

I think I'll just roll this PR's changes into #11270 since it already contained most of them. Closing for now.

@ncooke3 ncooke3 closed this May 12, 2023
@firebase firebase locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard left review comments

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: appcheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aiwenisevan @google-oss-bot @andrewheard @ncooke3
0