8000 Change log message to reference FID instead of IID by christibbs · Pull Request #5680 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

Change log message to reference FID instead of IID #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2020
Merged

Change log message to reference FID instead of IID #5680

merged 3 commits into from
May 27, 2020

Conversation

christibbs
Copy link
Contributor

We integrated FIS a few months ago, but never changed the log message that devs use to grab a token for testing FIAM on device.

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label May 26, 2020
paulb777
paulb777 reviewed May 26, 2020
View reviewed changes
Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get Maksym's approval ...

maksymmalyhin
maksymmalyhin approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor
@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christibbs christibbs merged commit b4faa55 into master May 27, 2020
@christibbs christibbs deleted the fiam-tod-log branch May 27, 2020 15:26
@firebase firebase locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@rohandandavati rohandandavati Awaiting requested review from rohandandavati

+1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@maksymmalyhin maksymmalyhin

Labels
api: inappmessaging Firebase In App Messaging cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christibbs @paulb777 @maksymmalyhin @googlebot @google-oss-bot
0