8000 chore: fix CI failure due for incorrect formatting by exaby73 · Pull Request #108 · firebase/firebase-functions-python · GitHub
[go: up one dir, main page]
Skip to content

chore: fix CI failure due for incorrect formatting #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2023
Merged

chore: fix CI failure due for incorrect formatting #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
763cca3
Run formmater
exaby73 Jun 19, 2023
77267ce
Add .idea to .gitignore
exaby73 Jun 19, 2023
5c1e6eb
Remove python.defaultInterpreterPath from settings.json
exaby73 Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,8 @@ pytest-coverage.txt
.DS_Store

# reference docs
doc/dist
doc/dist

# IDE files
.idea
.vscode
1 change: 0 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
],
"python.linting.pylintPath": "pylint",
"python.envFile": "${workspaceFolder}/venv",
"python.defaultInterpreterPath": "${workspaceFolder}/venv/bin/python3.10",
"editor.formatOnSave": true,
"python.linting.lintOnSave": true,
"python.linting.mypyEnabled": true,
Expand Down
3 changes: 1 addition & 2 deletions example/functions/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ def oncallexample(req: https_fn.CallableRequest):
return "Hello from https on call function example"


@pubsub_fn.on_message_published(
topic="hello",)
@pubsub_fn.on_message_published(topic="hello",)
def onmessagepublishedexample(
event: pubsub_fn.CloudEvent[pubsub_fn.MessagePublishedData]) -> None:
print("Hello from pubsub event:", event)
4 changes: 2 additions & 2 deletions samples/basic_alerts/functions/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
from firebase_functions.alerts import performance_fn


@alerts_fn.on_alert_published(alert_type=alerts_fn.AlertType.BILLING_PLAN_UPDATE
)
@alerts_fn.on_alert_published(
alert_type=alerts_fn.AlertType.BILLING_PLAN_UPDATE)
def onalertpublished(
alert: alerts_fn.AlertEvent[alerts_fn.FirebaseAlertData[
billing_fn.PlanUpdatePayload]]
Expand Down
0